linux-kernel - Re: [PATCH 24/25] PCI: Perform reset_resource() and build fail list in sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4a5855c-6d58-4fc5-85d7-4727d27efbe0@linaro.org>
Date: Tue, 3 Jun 2025 12:43:38 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
 Michał Winiarski <michal.winiarski@...el.com>,
 Igor Mammedov <imammedo@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 William McVicker <willmcvicker@...gle.com>
Subject: Re: [PATCH 24/25] PCI: Perform reset_resource() and build fail list
 in sync



On 6/3/25 11:48 AM, Tudor Ambarus wrote:
> 
> 
> On 6/3/25 11:36 AM, Tudor Ambarus wrote:
>>
>>
>> On 6/3/25 9:13 AM, Ilpo Järvinen wrote:
>>> So please test if this patch solves your problem:
>>
>> It fails in a different way, the bridge window resource never gets
>> assigned with the proposed patch.
>>
>> With the patch applied: https://termbin.com/h3w0
> 
> above is no revert and with the proposed fix. It also contains the
> prints https://termbin.com/g4zn
> 
> It seems the prints in pbus_size_mem are not longer hit, likely because
> of the new condition added: ``!pdev_resources_assignable(dev) ||``,
> pci_dev_for_each_resource() finishes without doing anything.
> 
>> With the blamed commit reverted: https://termbin.com/3rh6
> 

I think I found the inconsistency.

__pci_bus_assign_resources()
	pbus_assign_resources_sorted()
		pdev_sort_resources(dev, &head);

But pdev_sort_resources() is called with a newly LIST_HEAD(head), not
with realloc_head, thus the resources never get sorted.

pdev_sort_resources() exits early at
	``if (!pdev_resources_assignable(dev))``