linux-kernel - Re: [PATCH 24/25] PCI: Perform reset_resource() and build fail list in sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc611a93-1f5f-a86d-f3ca-cb737ed5fa4a@linux.intel.com>
Date: Tue, 3 Jun 2025 17:13:42 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org, 
    Michał Winiarski <michal.winiarski@...el.com>, 
    Igor Mammedov <imammedo@...hat.com>, LKML <linux-kernel@...r.kernel.org>, 
    Mika Westerberg <mika.westerberg@...ux.intel.com>, 
    William McVicker <willmcvicker@...gle.com>
Subject: Re: [PATCH 24/25] PCI: Perform reset_resource() and build fail list
 in sync

On Tue, 3 Jun 2025, Tudor Ambarus wrote:
> On 6/3/25 9:13 AM, Ilpo Järvinen wrote:
> > So please test if this patch solves your problem:
> 
> It fails in a different way, the bridge window resource never gets
> assigned with the proposed patch.

Is that a failure? I was expecting that to occur. It didn't assign 
any resources into that bridge window.

If there's nothing to be assigned into the bridge window, the bridge 
window itself is not created, that is the expected behavior (working as 
designed). So you're comparing to the bridge window that was made too 
large due to the disparity (and left unused, AFAICT).

It would be possible to put the condition inside the block which adds 
the resource to the realloc_head, I initially put it there but then 
decided to remove the disparity completely because why keep it if no 
resource is going to be placed into the bridge window.

What's that class 0 device anyway? Why it has class 0?

> With the patch applied: https://termbin.com/h3w0
> With the blamed commit reverted: https://termbin.com/3rh6

-- 
 i.