linux-kernel - Re: [PATCH] rust: acpi: add `acpi::DeviceId` abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG7QV936MPp7RLH_D6+K8mRcgPdpNsGFWF_D10b1C8op7YRtqA@mail.gmail.com>
Date: Tue, 3 Jun 2025 13:55:47 +0100
From: Igor Korotin <igor.korotin.linux@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Greg KH <gregkh@...uxfoundation.org>, "Rafael J . Wysocki" <rafael@...nel.org>, 
	Len Brown <lenb@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, linux-acpi@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: acpi: add `acpi::DeviceId` abstraction

> Alternatively, if you want to upstream this dependency already you can send the
> following patches:
>
>   - this acpi::DeviceId abstraction
>   - the glue code for the generic adapter trait in rust/kernel/driver.rs
>   - use this glue code in the platform abstraction
>   - add acpi support to the platform sample driver
>
> This way we can already validate that the code works correctly. All this is
> required anyways if the I2C device you write a driver for is on the platform
> bus.

A few questions if I may:
1. I committed to 4 different files: `acpi.rs`, `driver.rs`,
`platform.rs`, platform rust sample driver.
Should I commit all of this as one commit or split each part to a
separate commit and send it as a patch sequence?
2. From author's point of view, as Danilo noticed, `acpi table`
abstraction code is in general just copy-paste from `of table`
abstraction code. How should I explicitly mark that fact?

Thanks
Igor