linux-kernel - Re: [PATCH v3 2/5] PM: sleep: Suspend async parents after suspending children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aD76cCE5qyALjKHc@debian.local>
Date: Tue, 3 Jun 2025 14:36:48 +0100
From: Chris Bainbridge <chris.bainbridge@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Mario Limonciello <superm1@...nel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Johan Hovold <johan@...nel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Jon Hunter <jonathanh@...dia.com>,
	Saravana Kannan <saravanak@...gle.com>,
	amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH v3 2/5] PM: sleep: Suspend async parents after suspending
 children

On Tue, Jun 03, 2025 at 03:04:33PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jun 3, 2025 at 2:27 PM Chris Bainbridge
> <chris.bainbridge@...il.com> wrote:
> >
> > On Tue, 3 Jun 2025 at 13:24, Rafael J. Wysocki <rafael@...nel.org> wrote:
> > > >
> > > > This patch does fix the list corruption, but the "Unbalanced
> > > > pm_runtime_enable" still occurs:
> > >
> > > Have you applied it together with the previous patch?
> >
> > Yes
> 
> So it looks like some devices have power.is_suspended set from the
> previous cycle which causes device_resume() to attempt to resume them
> even though they have not been suspended in the current cycle yet.
> 
> Please try the attached patch in addition to the previous 2 patches.
> 
> Thanks!

That fixed it. Passed 30 attempted suspends without error.

Reported-and-tested-by: Chris Bainbridge <chris.bainbridge@...il.com>