linux-kernel - Re: [PATCH net-next] net: macb: Add shutdown operation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f3a9687-1dea-41fb-8567-1186d4fa2df2@lunn.ch>
Date: Tue, 3 Jun 2025 17:57:02 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Abin Joseph <abin.joseph@....com>
Cc: nicolas.ferre@...rochip.com, claudiu.beznea@...on.dev,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, git@....com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: macb: Add shutdown operation support

> +static void macb_shutdown(struct platform_device *pdev)
> +{
> +	struct net_device *netdev = dev_get_drvdata(&pdev->dev);
> +
> +	netif_device_detach(netdev);
> +	dev_close(netdev);
> +}

Have you tried this on a device which was admin down? It seems like
you get unbalanced open()/close() calls.

    Andrew