linux-kernel - RE: [PATCH net-next] net: macb: Add shutdown operation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CH3PR12MB9171B307A46A01455DBBA241FC6CA@CH3PR12MB9171.namprd12.prod.outlook.com>
Date: Wed, 4 Jun 2025 10:52:47 +0000
From: "Joseph, Abin" <Abin.Joseph@....com>
To: Andrew Lunn <andrew@...n.ch>
CC: "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
	"claudiu.beznea@...on.dev" <claudiu.beznea@...on.dev>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"git (AMD-Xilinx)" <git@....com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] net: macb: Add shutdown operation support

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Andrew,

>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Tuesday, June 3, 2025 9:27 PM
>To: Joseph, Abin <Abin.Joseph@....com>
>Cc: nicolas.ferre@...rochip.com; claudiu.beznea@...on.dev;
>andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
>kuba@...nel.org; pabeni@...hat.com; git (AMD-Xilinx) <git@....com>;
>netdev@...r.kernel.org; linux-kernel@...r.kernel.org
>Subject: Re: [PATCH net-next] net: macb: Add shutdown operation support
>
>Caution: This message originated from an External Source. Use proper caution when
>opening attachments, clicking links, or responding.
>
>
>> +static void macb_shutdown(struct platform_device *pdev) {
>> +     struct net_device *netdev = dev_get_drvdata(&pdev->dev);
>> +
>> +     netif_device_detach(netdev);
>> +     dev_close(netdev);
>> +}
>
>Have you tried this on a device which was admin down? It seems like you get
>unbalanced open()/close() calls.
>

Yes, I tested this on a device which was admin down using "ifconfig eth0 down". I observed that macb_close() is invoked only once,
specifically when the interface is bought down. During the kexec call the shutdown hook is triggered, but the close() won't be called
In this scenario.

Regards,
Abin Joseph

>    Andrew