linux-kernel - Re: [PATCH v2] platform/x86: Move Lenovo files into lenovo subdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEHzYT4XqhzIpO5k@smile.fi.intel.com>
Date: Thu, 5 Jun 2025 22:43:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Jonathan Corbet <corbet@....net>, ikepanhc@...il.com,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Armin Wolf <W_Armin@....de>, linux-doc@...r.kernel.org,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: Move Lenovo files into lenovo subdir

On Thu, Jun 05, 2025 at 11:53:47AM -0400, Mark Pearson wrote:
> On Thu, Jun 5, 2025, at 1:58 AM, Andy Shevchenko wrote:
> > On Wed, Jun 04, 2025 at 01:36:53PM -0400, Mark Pearson wrote:
> >> Create lenovo subdirectory for holding Lenovo specific drivers.

...

> >> -F:	drivers/platform/x86/lenovo-wmi-hotkey-utilities.c
> >> +F:	drivers/platform/x86/lenovo/lenovo-wmi-hotkey-utilities.c
> >
> > You may follow the trick in the Makefile (see intel folder) to avoid repetition
> > of the folder name in the file names. Note, the modules will be called the
> > same (assuming no ABI breakages due to renames).
> >
> Interesting - I'll have to look at that a bit more.
> Any objections if I leave that for a future change?

IF it's nearest future :-)

...

> >> -# IBM Thinkpad and Lenovo
> >> +# IBM Thinkpad
> >
> > This is a bit ambiguous now. It's IBM and Lenove for ThinkPad... Perhaps you
> > should put some kind of date or so? Like
> >
> > # IBM Thinkpad (before 2007)
> >
> > (note, I speculated on the year, you may know better what to put there).
> >
> 
> Sure. Realistically the thinkpad_acpi driver still works for the (pretty old
> now!) IBM Thinkpads so it's a bit messy.
> 
> Main reason I did this is those two IBM specific drivers aren't, to my
> understanding, active for Lenovo devices now, and it seemed wrong to move
> them. Not sure if anybody really cares though :) I just didn't want to step
> on any toes.
> 
> IBM sold the PC business to Lenovo in 2005, so I can put that date there
> unless anybody else has concerns.

Sounds good to me.

-- 
With Best Regards,
Andy Shevchenko