linux-kernel - Re: [PATCH v2] platform/x86: Move Lenovo files into lenovo subdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <63e00b35-361f-41ac-8341-f30c2e9dade9@app.fastmail.com>
Date: Thu, 05 Jun 2025 11:56:51 -0400
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: "Hans de Goede" <hdegoede@...hat.com>, "Jonathan Corbet" <corbet@....net>,
 ikepanhc@...il.com, "Henrique de Moraes Holschuh" <hmh@....eng.br>,
 "Armin Wolf" <W_Armin@....de>,
 "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 linux-doc@...r.kernel.org,
 "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
 ibm-acpi-devel@...ts.sourceforge.net, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] platform/x86: Move Lenovo files into lenovo subdir

Hi Ilpo

On Thu, Jun 5, 2025, at 4:03 AM, Ilpo Järvinen wrote:
> On Wed, 4 Jun 2025, Mark Pearson wrote:
>
>> Create lenovo subdirectory for holding Lenovo specific drivers.
>> 
>> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
>> ---
>> Changes in v2:
>>  - Rebased to Linus's latest as requested
>>  - Updated documentation reference
>>  - Updated MAINTAINER file
>>  - Removed X86_PLATFORM_DRIVERS_LENOVO as I was worried about
>>    maintaining backwards compatibility for the distros.
>>  - Removed 2nd patch in series splitting out hkeys. That will be for
>>    the future
>
> +# Lenovo x86 Platform-Specific Drivers
> +# Lenovo X86 Platform Specific Drivers
>
> Any possibility to be consistent in formatting that? :-)
>
Ooops - yes. I'll fix.

> Why does the admin guide contain a history book?? It should be guide for 
> this version of kernel, not what was there in 2.6.x era ;-D. Please don't 
> add to that any more, preferrably remove the history part afterwards in a 
> separate change.
>

Sure. Will remove that change from the commit.

I was just trying to make sure I updated in all the right places and realised I hadn't checked the documentation files and found that reference.

> Other than those mentioned above, diffing per vs post seemed clean (I 
> didn't check where the empty lines got added, Andy seemingly did already 
> :-)).
>
Thanks for the review.
Mark