linux-kernel - Re: [PATCH v2 1/1] dt-bindings: interrupt-controller: Add arm,armv7m-nvic and fix #interrupt-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250605125444.GA2354143-robh@kernel.org>
Date: Thu, 5 Jun 2025 07:54:44 -0500
From: Rob Herring <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:IRQCHIP DRIVERS" <linux-kernel@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	imx@...ts.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: interrupt-controller: Add
 arm,armv7m-nvic and fix #interrupt-cells

On Wed, May 28, 2025 at 12:37:04PM -0400, Frank Li wrote:
> According to existed dts arch/arm/boot/dts/armv7-m.dtsi and driver
> drivers/irqchip/irq-nvic.c, compatible string should be arm,armv7m-nvic,
> 
> Remove unused compatible string arm,v6m-nvic, arm,v7m-nvic and arm,v8m-nvic.
> 
> Fix below CHECK_DTB warning:
> 
> arch/arm/boot/dts/nxp/vf/vf610m4-cosmic.dtb: /interrupt-controller@...0e100:
>     failed to match any schema with compatible: ['arm,armv7m-nvic']
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> change in v2:
> - fix example interrupt-cells
> - commit message add driver information
> - remove unused compatible string
> ---
>  .../bindings/interrupt-controller/arm,nvic.yaml     | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,nvic.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,nvic.yaml
> index d89eca956c5fa..c0be00b450291 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,nvic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,nvic.yaml
> @@ -17,9 +17,7 @@ description:
>  properties:
>    compatible:
>      enum:
> -      - arm,v6m-nvic
> -      - arm,v7m-nvic
> -      - arm,v8m-nvic

These came from Zephyr and are in use:

https://docs.zephyrproject.org/latest/build/dts/api/bindings/interrupt-controller/arm%2Cv7m-nvic.html

> +      - arm,armv7m-nvic

Add '# deprecated' after it.

>  
>    reg:
>      maxItems: 1
> @@ -30,10 +28,10 @@ properties:
>    interrupt-controller: true
>  
>    '#interrupt-cells':
> -    const: 2
> +    const: 1

Have to support both.

>      description: |
>        Number of cells to encode an interrupt source:
> -      first = interrupt number, second = priority.
> +      first = interrupt number.
>  
>    arm,num-irq-priority-bits:
>      description: Number of priority bits implemented by the SoC
> @@ -45,15 +43,14 @@ required:
>    - reg
>    - interrupt-controller
>    - '#interrupt-cells'
> -  - arm,num-irq-priority-bits

Is there NVIC h/w without priority bits? If not, this should remain 
required.

>  
>  additionalProperties: false
>  
>  examples:
>    - |
>      interrupt-controller@...0e100 {
> -        compatible = "arm,v7m-nvic";
> -        #interrupt-cells = <2>;
> +        compatible = "arm,armv7m-nvic";
> +        #interrupt-cells = <1>;
>          #address-cells = <0>;
>          interrupt-controller;
>          reg = <0xe000e100 0xc00>;
> -- 
> 2.34.1
>