linux-kernel - Re: [PATCH 1/2] clocksource: fix opencoded cpumask_any_but() in clocksource_verify_choose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANDhNCq5qLFe5mLQi8RQGU24ERdsvpLwBE3GRJ4HdU4caJZNDA@mail.gmail.com>
Date: Thu, 5 Jun 2025 11:13:26 -0700
From: John Stultz <jstultz@...gle.com>
To: Yury Norov <yury.norov@...il.com>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>, 
	Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH 1/2] clocksource: fix opencoded cpumask_any_but() in clocksource_verify_choose_cpus()

On Wed, Jun 4, 2025 at 4:25 PM Yury Norov <yury.norov@...il.com> wrote:
>
> From: Yury Norov [NVIDIA] <yury.norov@...il.com>
>
> cpumask_any_but() is more verbose than cpumask_first() followed by
> cpumask_next(). Use it in clocksource_verify_choose_cpus().
>
> Signed-off-by: Yury Norov [NVIDIA] <yury.norov@...il.com>
> ---
>  kernel/time/clocksource.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 4b005b2f3ef5..2e24ce884272 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -323,9 +323,7 @@ static void clocksource_verify_choose_cpus(void)
>                 return;
>
>         /* Make sure to select at least one CPU other than the current CPU. */
> -       cpu = cpumask_first(cpu_online_mask);
> -       if (cpu == smp_processor_id())
> -               cpu = cpumask_next(cpu, cpu_online_mask);
> +       cpu = cpumask_any_but(cpu_online_mask, smp_processor_id());
>         if (WARN_ON_ONCE(cpu >= nr_cpu_ids))
>                 return;
>         cpumask_set_cpu(cpu, &cpus_chosen);

Acked-by: John Stultz <jstultz@...gle.com>

Same nit comment from the other patch, just need to capitalize the
commit description in the subject.
  "clocksource: Fix opencoded..."

thanks
-john