linux-kernel - Re: [PATCH 2/2] clocksource: fix opencoded cpumask_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCqbJZejdVqDJ8BnBstq1FAk5AiAvAo7sRnrKC41mCZ5nQ@mail.gmail.com>
Date: Thu, 5 Jun 2025 11:11:38 -0700
From: John Stultz <jstultz@...gle.com>
To: Yury Norov <yury.norov@...il.com>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>, 
	Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH 2/2] clocksource: fix opencoded cpumask_next_wrap()

On Wed, Jun 4, 2025 at 4:25 PM Yury Norov <yury.norov@...il.com> wrote:
>
> From: Yury Norov [NVIDIA] <yury.norov@...il.com>
>
> cpumask_next_wrap() is more verbose and efficient comparing to
> cpumask_next() followed by cpumask_first().
>
> Signed-off-by: Yury Norov [NVIDIA] <yury.norov@...il.com>
> ---
>  kernel/time/clocksource.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 2e24ce884272..0aef0e349e49 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -584,9 +584,7 @@ static void clocksource_watchdog(struct timer_list *unused)
>          * Cycle through CPUs to check if the CPUs stay synchronized
>          * to each other.
>          */
> -       next_cpu = cpumask_next(raw_smp_processor_id(), cpu_online_mask);
> -       if (next_cpu >= nr_cpu_ids)
> -               next_cpu = cpumask_first(cpu_online_mask);
> +       next_cpu = cpumask_next_wrap(raw_smp_processor_id(), cpu_online_mask);
>

This looks ok to me. The only nit is that often folks like to see the
$Subject line look like:
  $topic: Capitalized description.

So for this one:
  clocksource: Fix opencoded cpumask_next_wrap()

Acked-by: John Stultz <jstultz@...gle.com>
thanks
-john