linux-kernel - [PATCH] mm/debug: Use BUILD_BUG_ON_INVALID() for VIRTUAL_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250607-virtual_bug_on_invalid-v1-1-b792ac2b0920@columbia.edu>
Date: Sat, 07 Jun 2025 03:09:19 -0400
From: Tal Zussman <tz2294@...umbia.edu>
To: Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Tal Zussman <tz2294@...umbia.edu>
Subject: [PATCH] mm/debug: Use BUILD_BUG_ON_INVALID() for VIRTUAL_BUG_ON()

This allows the compiler to validate the condition even with
CONFIG_DEBUG_VIRTUAL disabled, and aligns VIRTUAL_BUG_ON() with the
other macros in mmdebug.h.

Signed-off-by: Tal Zussman <tz2294@...umbia.edu>
---
 include/linux/mmdebug.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index a0a3894900ed..012aef40e7a9 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -129,7 +129,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
 #ifdef CONFIG_DEBUG_VIRTUAL
 #define VIRTUAL_BUG_ON(cond) BUG_ON(cond)
 #else
-#define VIRTUAL_BUG_ON(cond) do { } while (0)
+#define VIRTUAL_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond)
 #endif
 
 #ifdef CONFIG_DEBUG_VM_PGFLAGS

---
base-commit: efe99fabeb11b030c89a7dc5a5e7a7558d0dc7ec
change-id: 20250607-virtual_bug_on_invalid-81d24b276109

Best regards,
-- 
Tal Zussman <tz2294@...umbia.edu>