linux-kernel - Re: [PATCH v4 1/2] dt-bindings: leds: Add new as3668 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3e1e527-07e4-4288-a446-19fdcfd57733@kernel.org>
Date: Sun, 8 Jun 2025 16:41:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukas Timmermann <linux@...mermann.space>, lee@...nel.org,
 pavel@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add new as3668 support

On 07/06/2025 23:50, Lukas Timmermann wrote:
> This patch documents the device tree bindings for

Your previous style was correct. I don't get why you changed it to
incorrect "This patch".

See longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> the OSRAM AS3668 LED driver. Note that the bindings
> are not entirely complete, as the GPIO/Audio Input pin
> is undocumented. The hardware used for testing this patch series
> does not allow modification, so this pin has been omitted.
> 
> Signed-off-by: Lukas Timmermann <linux@...mermann.space>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, just skip it entirely
(please do not feel offended by me posting it here - no bad intentions
intended, no patronizing, I just want to avoid wasted efforts). If you
do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here ('b4 trailers -u ...'). However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591
</form letter>

Best regards,
Krzysztof