linux-kernel - Re: [PATCH v4 2/2] leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506081754.yXYFC7WL-lkp@intel.com>
Date: Sun, 8 Jun 2025 17:47:24 +0800
From: kernel test robot <lkp@...el.com>
To: Lukas Timmermann <linux@...mermann.space>, lee@...nel.org,
	pavel@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux@...mermann.space
Subject: Re: [PATCH v4 2/2] leds: as3668: Driver for the ams Osram 4-channel
 i2c LED driver

Hi Lukas,

kernel test robot noticed the following build errors:

[auto build test ERROR on lee-leds/for-leds-next]
[also build test ERROR on linus/master v6.15 next-20250606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lukas-Timmermann/dt-bindings-leds-Add-new-as3668-support/20250608-055330
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link:    https://lore.kernel.org/r/20250607215049.29259-3-linux%40timmermann.space
patch subject: [PATCH v4 2/2] leds: as3668: Driver for the ams Osram 4-channel i2c LED driver
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20250608/202506081754.yXYFC7WL-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250608/202506081754.yXYFC7WL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506081754.yXYFC7WL-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/leds/leds-as3668.c:137:16: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     137 |         chip_serial = FIELD_GET(AS3668_CHIP_ID2_SERIAL_MASK, chip_id2);
         |                       ^
   1 error generated.


vim +/FIELD_GET +137 drivers/leds/leds-as3668.c

   117	
   118	static int as3668_probe(struct i2c_client *client)
   119	{
   120		u8 chip_id1, chip_id2, chip_serial, chip_rev;
   121		struct as3668 *as3668;
   122	
   123		/* Check for sensible i2c address */
   124		if (client->addr != 0x42)
   125			return dev_err_probe(&client->dev, -EFAULT,
   126					     "unexpected address for as3668 device\n");
   127	
   128		/* Read identifier from chip */
   129		chip_id1 = as3668_read_value(client, AS3668_CHIP_ID1);
   130	
   131		if (chip_id1 != AS3668_CHIP_IDENT)
   132			return dev_err_probe(&client->dev, -ENODEV,
   133					"chip reported wrong id: 0x%tx\n", chip_id1);
   134	
   135		/* Check the revision*/
   136		chip_id2 = as3668_read_value(client, AS3668_CHIP_ID2);
 > 137		chip_serial = FIELD_GET(AS3668_CHIP_ID2_SERIAL_MASK, chip_id2);
   138		chip_rev = FIELD_GET(AS3668_CHIP_ID2_REV_MASK, chip_id2);
   139	
   140		if (chip_rev != AS3668_CHIP_REV1)
   141			dev_warn(&client->dev, "unexpected chip revision\n");
   142	
   143		/* Print out information about the chip */
   144		dev_dbg(&client->dev,
   145			"chip_id: 0x%tx | chip_id2: 0x%tx | chip_serial: 0x%tx | chip_rev: 0x%tx\n",
   146			chip_id1, chip_id2, chip_serial, chip_rev);
   147	
   148		as3668 = devm_kzalloc(&client->dev, struct_size(as3668, leds, AS3668_MAX_LEDS), GFP_KERNEL);
   149		as3668->client = client;
   150	
   151		as3668_dt_init(as3668);
   152	
   153		/* Initialize the chip */
   154		as3668_write_value(client, AS3668_CURRX_CONTROL, 0x55);
   155		as3668_write_value(client, AS3668_CURR1, 0x00);
   156		as3668_write_value(client, AS3668_CURR2, 0x00);
   157		as3668_write_value(client, AS3668_CURR3, 0x00);
   158		as3668_write_value(client, AS3668_CURR4, 0x00);
   159	
   160		return 0;
   161	}
   162	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki