linux-kernel - Re: [PATCH v2 2/5] power: supply: core: remove of_node from power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6e1c8af-dd37-4ea6-b076-dd1f1d9a11a0@kernel.org>
Date: Sun, 8 Jun 2025 21:26:01 +0200
From: Hans de Goede <hansg@...nel.org>
To: Sebastian Reichel <sebastian.reichel@...labora.com>,
 Sebastian Reichel <sre@...nel.org>, Mark Brown <broonie@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>,
 Matti Vaittinen <mazziesaccount@...il.com>, Pali Rohár
 <pali@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-phy@...r.kernel.org
Subject: Re: [PATCH v2 2/5] power: supply: core: remove of_node from
 power_supply_config

Hi,

On 30-Apr-25 12:54 AM, Sebastian Reichel wrote:
> All drivers have been migrated from .of_node to .fwnode,
> so let's kill the former.
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@...nel.org>

Regards,

Hans


> ---
>  drivers/power/supply/power_supply_core.c | 3 +--
>  include/linux/power_supply.h             | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index 33a5bfce4604f012344733ba489eda1c5e8b92c0..89947f1fe610d8a75756e1e4e5339b06349f9ab8 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -1529,10 +1529,9 @@ __power_supply_register(struct device *parent,
>  	dev_set_drvdata(dev, psy);
>  	psy->desc = desc;
>  	if (cfg) {
> +		device_set_node(dev, cfg->fwnode);
>  		dev->groups = cfg->attr_grp;
>  		psy->drv_data = cfg->drv_data;
> -		dev->of_node =
> -			cfg->fwnode ? to_of_node(cfg->fwnode) : cfg->of_node;
>  		psy->supplied_to = cfg->supplied_to;
>  		psy->num_supplicants = cfg->num_supplicants;
>  	}
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index c4cb854971f53a244ba7742a15ce7a5515da6199..b6eb31a23c878aa9ed8ad7bcb02a13721354e1cb 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -229,7 +229,6 @@ struct power_supply;
>  
>  /* Run-time specific power supply configuration */
>  struct power_supply_config {
> -	struct device_node *of_node;
>  	struct fwnode_handle *fwnode;
>  
>  	/* Driver private data */
>