linux-kernel - Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEdBy6m_6aQr8l41@smile.fi.intel.com>
Date: Mon, 9 Jun 2025 23:19:23 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: ilpo.jarvinen@...ux.intel.com, hdegoede@...hat.com, corbet@....net,
	ikepanhc@...il.com, hmh@....eng.br, W_Armin@....de,
	linux-doc@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling

On Mon, Jun 09, 2025 at 08:27:25AM -0400, Mark Pearson wrote:
> Fix issues reported by kernel test robot.
>  - Require DMI for think-lmi.
>  - Check return from getting serial string
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506062319.F0IpDxF6-lkp@intel.com/

> 

No blank line in tag block.

> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>

>  - New patch added to series.

Shouldn't it be the first one in the series? It seems to me that this is the
fix of the original code as well.

...

> +++ b/drivers/platform/x86/lenovo/think-lmi.c

My understanding is that you need either Kconfig or changing C file.

-- 
With Best Regards,
Andy Shevchenko