linux-kernel - Re: [PATCH 2/3] driver core: faux: Quiet probe failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250609111915.000011a1@huawei.com>
Date: Mon, 9 Jun 2025 11:19:15 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Dan Williams <dan.j.williams@...el.com>
CC: <gregkh@...uxfoundation.org>, <rafael.j.wysocki@...el.com>,
	<linux-cxl@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH 2/3] driver core: faux: Quiet probe failures

On Fri, 6 Jun 2025 20:32:27 -0700
Dan Williams <dan.j.williams@...el.com> wrote:

> The acpi-einj conversion to faux_device_create() leads to a noisy error
> message when the error injection facility is disabled. Quiet the error as
> CXL error injection via ACPI expects the module to stay loaded even if the
> error injection facility is disabled.
> 
> This situation arose because CXL knows proper kernel named objects to
> trigger errors against, but acpi-einj knows how to perform the error
> injection. The injection mechanism is shared with non-CXL use cases. The
> result is CXL now has a module dependency on einj-core.ko, and init/probe
> failures are handled at runtime.
> 
> Fixes: 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface")
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Danilo Krummrich <dakr@...nel.org>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

I guess this is fair enough. 

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/base/faux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/faux.c b/drivers/base/faux.c
> index 934da77ca48b..f5fbda0a9a44 100644
> --- a/drivers/base/faux.c
> +++ b/drivers/base/faux.c
> @@ -170,7 +170,7 @@ struct faux_device *faux_device_create_with_groups(const char *name,
>  	 * successful is almost impossible to determine by the caller.
>  	 */
>  	if (!dev->driver) {
> -		dev_err(dev, "probe did not succeed, tearing down the device\n");
> +		dev_dbg(dev, "probe did not succeed, tearing down the device\n");
>  		faux_device_destroy(faux_dev);
>  		faux_dev = NULL;
>  	}