linux-kernel - Re: [PATCH 1/3] driver core: faux: Suppress bind attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250609111957.00003c07@huawei.com>
Date: Mon, 9 Jun 2025 11:19:57 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Dan Williams <dan.j.williams@...el.com>
CC: <gregkh@...uxfoundation.org>, <rafael.j.wysocki@...el.com>,
	<linux-cxl@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH 1/3] driver core: faux: Suppress bind attributes

On Fri, 6 Jun 2025 20:32:26 -0700
Dan Williams <dan.j.williams@...el.com> wrote:

> faux_device_create() is almost a suitable candidate to replace
> platform_driver_probe() if not for the fact that faux_device_create()
> supports dynamic attach/detach of the driver.
> 
> Drop the bind attributes with the expectation that simple faux devices can
> always assume that the device is permanently bound at create, and only
> unbound at 'destroy'.
> 
> The acpi-einj driver depends on static bind.
> 
> Fixes: 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface")
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Danilo Krummrich <dakr@...nel.org>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
Seems like a fair assumption that these should never be used so
we might as well hide the.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/base/faux.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/base/faux.c b/drivers/base/faux.c
> index 9054d346bd7f..934da77ca48b 100644
> --- a/drivers/base/faux.c
> +++ b/drivers/base/faux.c
> @@ -86,6 +86,7 @@ static struct device_driver faux_driver = {
>  	.name		= "faux_driver",
>  	.bus		= &faux_bus_type,
>  	.probe_type	= PROBE_FORCE_SYNCHRONOUS,
> +	.suppress_bind_attrs = true,
>  };
>  
>  static void faux_device_release(struct device *dev)