linux-kernel - Re: [PATCH v4 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a46bf855-e9fc-44c4-9219-7d91651b30d3@lunn.ch>
Date: Mon, 9 Jun 2025 14:24:34 +0200
From: Andrew Lunn <andrew@...n.ch>
To: george.moussalem@...look.com
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v4 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018
 Internal PHY support

> -#include <linux/phy.h>
> -#include <linux/module.h>
> -#include <linux/string.h>
> -#include <linux/netdevice.h>
> +#include <linux/bitfield.h>
> +#include <linux/clk.h>
> +#include <linux/clk-provider.h>
>  #include <linux/etherdevice.h>
>  #include <linux/ethtool_netlink.h>
> -#include <linux/bitfield.h>
> -#include <linux/regulator/of_regulator.h>
> -#include <linux/regulator/driver.h>
> -#include <linux/regulator/consumer.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> +#include <linux/netdevice.h>
>  #include <linux/of.h>
> +#include <linux/phy.h>
>  #include <linux/phylink.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/of_regulator.h>
> +#include <linux/reset.h>
>  #include <linux/sfp.h>
> +#include <linux/string.h>
>  #include <dt-bindings/net/qca-ar803x.h>

Please sort the headers in a separate patch. Cleanup and new features
are logically different things, so should not be mixed.

> +static void ipq5018_link_change_notify(struct phy_device *phydev)
> +{
> +	mdiobus_modify_changed(phydev->mdio.bus, phydev->mdio.addr,
> +			       IPQ5018_PHY_FIFO_CONTROL, IPQ5018_PHY_FIFO_RESET,
> +			       phydev->link ? IPQ5018_PHY_FIFO_RESET : 0);
> +}


link_change_notify is pretty much only used when the PHY is broken. So
it would be good to add a comment what is happening here. Why does the
FIFO need to be reset?

	Andrew