linux-kernel - Re: [PATCH v4 2/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d56f57a7-79f5-4cb2-b4af-fdb88db69ef4@lunn.ch>
Date: Mon, 9 Jun 2025 14:30:37 +0200
From: Andrew Lunn <andrew@...n.ch>
To: George Moussalem <george.moussalem@...look.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v4 2/5] dt-bindings: net: qca,ar803x: Add IPQ5018
 Internal GE PHY support

On Mon, Jun 09, 2025 at 04:20:12PM +0400, George Moussalem wrote:
> 
> 
> On 6/9/25 16:16, Andrew Lunn wrote:
> > > +  - |
> > > +    #include <dt-bindings/reset/qcom,gcc-ipq5018.h>
> > > +
> > > +    mdio {
> > > +        #address-cells = <1>;
> > > +        #size-cells = <0>;
> > > +
> > > +        /* add alias to set qcom,dac-preset-short-cable on boards that need it */
> > > +        ge_phy: ethernet-phy@7 {
> > > +            compatible = "ethernet-phy-id004d.d0c0";
> > > +            reg = <7>;
> > > +
> > > +            resets = <&gcc GCC_GEPHY_MISC_ARES>;
> > 
> > What do you mean by 'alias' here?
> 
> I mean node label. Since it was asked whether it's needed, I added a comment
> to say why, so that boards can reference it to set the
> qcom,dac-preset-short-cable property in the DTS as needed.

Ah, O.K.

Since this is internal, it is in the SoC .dtsi file. A board would
need to add the property in its .dts file, and so need a label.

The example itself does not need it, but the real version does. If it
was one of the DT Maintainers who asked for it, then O.K. 

	Andrew