linux-kernel - Re: [PATCH] reboot: Remove unused unregister_platform_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEbSlN7BYT5qVlyb@gallifrey>
Date: Mon, 9 Jun 2025 12:24:52 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Dmitry Osipenko <dmitry.osipenko@...labora.com>, rafael@...nel.org
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reboot: Remove unused unregister_platform_power_off

* Dmitry Osipenko (dmitry.osipenko@...labora.com) wrote:
> Hi,
> 
> On 6/8/25 20:42, linux@...blig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > unregister_platform_power_off() was added as part of 2022's
> > commit fb61375ecfba ("kernel/reboot: Add register_platform_power_off()")
> > but has remained unused.
> > 
> > Remove it.
> > 
> > Note it's a pair with register_platform_power_off() so
> > seems symmetric; however, I think platforms are chosen
> > and then stay that way for the boot - so don't
> > get unregistered.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > ---
> >  include/linux/reboot.h |  1 -
> >  kernel/reboot.c        | 16 ----------------
> >  2 files changed, 17 deletions(-)
> 
> The patches converting those platform drivers to use
> register[un]_platform_power_off() haven't been sent to ML. This is the
> reason this func is unused.

Ah

> There were apm_32 [1], platform/iris [2], mcu_mpc8349emitx [3],
> olpc-xo1-pm [4] and sgy_cts1000 [5] drivers that I had patches prepared
> to convert them to new power-off API. They weren't sent out back then in
> 2022 because of a nontrivial dependencies between drivers. At least some
> of those deps has been resolved by now and potentially the API
> conversion may continue. Currently other things keep me busy and don't
> have immediate plans to continue the conversion work, maybe sometime later.

Yeh that's life!
Of course if you could upstream one to get it rolling that would
be great, but I understand.
Most of those seem pretty old platforms, what makes those
different?

> Leaving it up to Rafael to decide whether to keep this func unused or
> re-add later, once it actually will become needed.

I've copied Rafael into the thread.

Dave
> [1]
> https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/e42f1264161085f01fed16986a23592519d9f49e
> [2]
> https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/24cd048ad801aab6221f2b0bb4576dfc2fe25faa
> [3]
> https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/486b69b43c47d85a0f292dca127f0b9063443a54
> [4]
> https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/fe5344b3f8a8e1c52e1cd7108aa7e615123be4b2
> [5]
> https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/0d761d6139c9dacbbda9f2e095577b084685603f
> 
> -- 
> Best regards,
> Dmitry
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/