linux-kernel - Re: [PATCH] reboot: Remove unused unregister_platform_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <582f86fb-bcf1-4b58-ad54-acacf4326dd1@collabora.com>
Date: Sun, 8 Jun 2025 23:03:06 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: linux@...blig.org, akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reboot: Remove unused unregister_platform_power_off

Hi,

On 6/8/25 20:42, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> unregister_platform_power_off() was added as part of 2022's
> commit fb61375ecfba ("kernel/reboot: Add register_platform_power_off()")
> but has remained unused.
> 
> Remove it.
> 
> Note it's a pair with register_platform_power_off() so
> seems symmetric; however, I think platforms are chosen
> and then stay that way for the boot - so don't
> get unregistered.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  include/linux/reboot.h |  1 -
>  kernel/reboot.c        | 16 ----------------
>  2 files changed, 17 deletions(-)

The patches converting those platform drivers to use
register[un]_platform_power_off() haven't been sent to ML. This is the
reason this func is unused.

There were apm_32 [1], platform/iris [2], mcu_mpc8349emitx [3],
olpc-xo1-pm [4] and sgy_cts1000 [5] drivers that I had patches prepared
to convert them to new power-off API. They weren't sent out back then in
2022 because of a nontrivial dependencies between drivers. At least some
of those deps has been resolved by now and potentially the API
conversion may continue. Currently other things keep me busy and don't
have immediate plans to continue the conversion work, maybe sometime later.

Leaving it up to Rafael to decide whether to keep this func unused or
re-add later, once it actually will become needed.

[1]
https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/e42f1264161085f01fed16986a23592519d9f49e
[2]
https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/24cd048ad801aab6221f2b0bb4576dfc2fe25faa
[3]
https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/486b69b43c47d85a0f292dca127f0b9063443a54
[4]
https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/fe5344b3f8a8e1c52e1cd7108aa7e615123be4b2
[5]
https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/0d761d6139c9dacbbda9f2e095577b084685603f

-- 
Best regards,
Dmitry