linux-kernel - Re: [PATCH] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04b5b857-4996-4278-8fab-7eb816b1febe@lechnology.com>
Date: Mon, 9 Jun 2025 09:46:31 -0500
From: David Lechner <david@...hnology.com>
To: "Rob Herring (Arm)" <robh@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema

On 6/7/25 4:26 PM, Rob Herring (Arm) wrote:
> Convert the TI DA830 USB PHY binding to DT schema format. Add "clocks"
> and "clock-names" which are already in use.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---

...

> diff --git a/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
> new file mode 100644
> index 000000000000..e18746f80982
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/ti,da830-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DA8xx/OMAP-L1xx/AM18xx USB PHY
> +
> +maintainers:
> +  - David Lechner <david@...hnology.com>
> +
> +description: >
> +  This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
> +  controllers on DA8xx SoCs. Consumers of this device should use index 0 for
> +  the USB 2.0 phy device and index 1 for the USB 1.1 phy device.

Probably doesn't matter much, but we could move the description
of the #phy-cells to that property.

> +
> +  It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon"
> +  to access the CFGCHIP2 register.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: ti,da830-usb-phy
> +
> +  '#phy-cells':
> +    const: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: usb0_clk48
> +      - const: usb1_clk48
> +
> +required:
> +  - compatible
> +  - '#phy-cells'

Probably should make clocks and clock-names required.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usb-phy {
> +        compatible = "ti,da830-usb-phy";
> +        #phy-cells = <1>;
> +        clocks = <&usb_phy_clk 0>, <&usb_phy_clk 1>;
> +        clock-names = "usb0_clk48", "usb1_clk48";
> +    };