linux-kernel - Re: [PATCH 1/2] tools/nolibc: Provide vfork()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df6f5620-5986-4080-bb00-c7bee856bf66@t-8ch.de>
Date: Mon, 9 Jun 2025 17:34:33 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Mark Brown <broonie@...nel.org>
Cc: Willy Tarreau <w@....eu>, Christian Brauner <brauner@...nel.org>, 
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Shuah Khan <shuah@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/2] tools/nolibc: Provide vfork()

Small followup review, sorry for the noise.

On 2025-06-09 16:08:56+0100, Mark Brown wrote:
<snip>

> +#ifndef sys_vfork

This ifndef is not necessary here.
No architecture has a special version.

> +static __attribute__((unused))
> +pid_t sys_vfork(void)
> +{
> +#ifdef __NR_vfork

For consistency:
#if defined(__NR_vfork)

> +	return my_syscall0(__NR_vfork);
> +#elif defined(__NR_clone3)
> +	/*
> +	 * clone() could be used but has different argument orders per
> +	 * architecture.
> +	 */
> +	struct clone_args args = {
> +		.flags		= CLONE_VM | CLONE_VFORK,
> +		.exit_signal	= SIGCHLD,
> +	};
> +
> +	return my_syscall2(__NR_clone3, &args, sizeof(args));
> +#else
> +	return __nolibc_enosys(__func__);
> +#endif
> +}
> +#endif