linux-kernel - Re: [PATCH 1/2] tools/nolibc: Provide vfork()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a4ef323-25e9-4bb5-bde4-9ad740693246@sirena.org.uk>
Date: Mon, 9 Jun 2025 16:43:55 +0100
From: Mark Brown <broonie@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Willy Tarreau <w@....eu>, Christian Brauner <brauner@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Shuah Khan <shuah@...nel.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/2] tools/nolibc: Provide vfork()

On Mon, Jun 09, 2025 at 05:34:33PM +0200, Thomas Weißschuh wrote:
> On 2025-06-09 16:08:56+0100, Mark Brown wrote:

> > +#ifndef sys_vfork

> This ifndef is not necessary here.
> No architecture has a special version.

Ah, I was adding it defensively in case it was needed in future.

> > +static __attribute__((unused))
> > +pid_t sys_vfork(void)
> > +{
> > +#ifdef __NR_vfork

> For consistency:
> #if defined(__NR_vfork)

Are you sure?  I'm seeing an awful lot of #ifdef __NR_foo instances in
sys.h - it looks like the idiom is to use that unless it either needs an
additional condition (with || or &&) or is an elif.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)