linux-kernel - Re: [PATCH v4] rust: regulator: add a bare minimum regulator abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <09F9A01B-70CA-421C-9A48-E0FD0A192026@collabora.com>
Date: Mon, 9 Jun 2025 13:30:52 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v4] rust: regulator: add a bare minimum regulator
 abstraction

Hi Miguel,

Sure, thank you!

By the way, are you using some lint to generate this?

> On 9 Jun 2025, at 13:23, Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:
> 
> On Mon, Jun 9, 2025 at 5:34 PM Daniel Almeida
> <daniel.almeida@...labora.com> wrote:
>> 
>> Add a bare minimum regulator abstraction to be used by Rust drivers.
>> This abstraction adds a small subset of the regulator API, which is
>> thought to be sufficient for the drivers we have now.
> 
> For future versions, or at apply time, please see the attached diff
> for some documentation fixes (mostly) -- please check with
> `--ignore-space-change`, since some indentation fixes can hide other
> changes.
> 
> Most should be self-explanatory, but if there is something that you
> think should not be done, please let me know of course.
> 
> Thanks!
> 
> Cheers,
> Miguel
> <docfixes.diff>


Also,

> -/// Enabling a regulator:
> +/// ## Enabling a regulator
>  ///

Did you try to render this? I tried it before submitting, but it did not render
correctly after the first time it was used, i.e.: only the first subsection was
rendered correctly and the others remained as-is.

— Daniel