linux-kernel - Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a43965e2-f0f2-40d5-b7cb-f79bd0261d06@intel.com>
Date: Tue, 10 Jun 2025 08:07:59 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Em Sharnoff <sharnoff@...n.tech>, linux-kernel@...r.kernel.org,
 x86@...nel.org, linux-mm@...ck.org
Cc: Ingo Molnar <mingo@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, Andy Lutomirski
 <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>,
 "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
 Oleg Vasilev <oleg@...n.tech>, Arthur Petukhovsky <arthur@...n.tech>,
 Stefan Radig <stefan@...n.tech>, Misha Sakhnov <misha@...n.tech>
Subject: Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*_init()

On 6/10/25 03:16, Em Sharnoff wrote:
> +		/*
> +		 * phys_{ppmd,pud,p4d}_init return allocation errors via ERR_PTR.

			 ^ typo?

> +		 * phys_pte_init makes no allocations, so should not error.
> +		 */
> +		BUG_ON(IS_ERR((void *)paddr_last));