linux-kernel - Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2080ec7c-8dc8-4f03-bd96-78ba47e55a97@neon.tech>
Date: Wed, 11 Jun 2025 09:38:11 +0100
From: Em Sharnoff <sharnoff@...n.tech>
To: Dave Hansen <dave.hansen@...el.com>, linux-kernel@...r.kernel.org,
 x86@...nel.org, linux-mm@...ck.org
Cc: Ingo Molnar <mingo@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
 Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>,
 "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
 Oleg Vasilev <oleg@...n.tech>, Arthur Petukhovsky <arthur@...n.tech>,
 Stefan Radig <stefan@...n.tech>, Misha Sakhnov <misha@...n.tech>
Subject: Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*_init()

On 6/10/25 15:55, Dave Hansen wrote:

> Are there any _actual_ users of 'paddr_last'? I see a lot of setting it
> and passing it around, but I _think_ this is the only place it actually
> gets used. Here, the fact that it's an address doesn't even matter.

I checked and didn't find any other users, but I'm happy to give others a
chance to correct me in case I missed something.

> Could you please find a way to reduce the number of casts?

What do you think about changing the return for these functions to just 'int'
for errors?
It's a larger change (especially if all callers should be updated to check the
return value), but I think much cleaner in the end.

> Please write everything in imperative voice. No "we's", please.

Noted, thanks - will address in the next version.

Em