linux-kernel - Re: [PATCH v6 1/8] dt-bindings: serial: describe SA8255p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d744b518-2ae9-4ca0-86ce-11cf74c945e6@quicinc.com>
Date: Tue, 10 Jun 2025 13:40:20 +0530
From: Praveen Talari <quic_ptalari@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby
	<jirislaby@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <psodagud@...cinc.com>, <djaggi@...cinc.com>,
        <quic_msavaliy@...cinc.com>, <quic_vtanuku@...cinc.com>,
        <quic_arandive@...cinc.com>, <quic_mnaresh@...cinc.com>,
        <quic_shazhuss@...cinc.com>, Nikunj Kela
	<quic_nkela@...cinc.com>
Subject: Re: [PATCH v6 1/8] dt-bindings: serial: describe SA8255p

Hi Krzysztof

Thank you for review.

On 6/10/2025 12:34 PM, Krzysztof Kozlowski wrote:
> On Fri, Jun 06, 2025 at 10:51:07PM GMT, Praveen Talari wrote:
>> From: Nikunj Kela <quic_nkela@...cinc.com>
>>
>> SA8255p platform abstracts resources such as clocks, interconnect and
>> GPIO pins configuration in Firmware. SCMI power and perf protocols are
>> used to send request for resource configurations.
>>
>> Add DT bindings for the QUP GENI UART controller on sa8255p platform.
>>
>> The wakeup interrupt (IRQ) is treated as optional, as not all UART
>> instances have a wakeup-capable interrupt routed via the PDC.
>>
>> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
>> Co-developed-by: Praveen Talari <quic_ptalari@...cinc.com>
>> Signed-off-by: Praveen Talari <quic_ptalari@...cinc.com>
>> ---
>> v5 -> v6
>> - added description for interrupt-names
>> - added wakeup irq as optional information in commit text and
>>    property description.
>> - removed wake irq form example node.
>>
>> v4 -> v5
>> - added wake irq in example node
>>
>> v3 -> v4
>> - added version log after ---
>>
>> v2 -> v3
>> - dropped description for interrupt-names
>> - rebased reg property order in required option
>>
>> v1 -> v2
>> - reorder sequence of tags in commit text
>> - moved reg property after compatible field
>> - added interrupt-names property
>> ---
>>   .../serial/qcom,sa8255p-geni-uart.yaml        | 68 +++++++++++++++++++
>>   1 file changed, 68 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/serial/qcom,sa8255p-geni-uart.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/serial/qcom,sa8255p-geni-uart.yaml b/Documentation/devicetree/bindings/serial/qcom,sa8255p-geni-uart.yaml
>> new file mode 100644
>> index 000000000000..c2e11ddcc0f6
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/serial/qcom,sa8255p-geni-uart.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/serial/qcom,sa8255p-geni-uart.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Geni based QUP UART interface
>> +
>> +maintainers:
>> +  - Praveen Talari <quic_ptalari@...cinc.com>
>> +
>> +allOf:
>> +  - $ref: /schemas/serial/serial.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,sa8255p-geni-uart
>> +      - qcom,sa8255p-geni-debug-uart
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    minItems: 1
> 
> Drop, this is not in sync with interrupt-names. You already received
> comments on this. We talk about this since v4!
I hope you have reviewed the commit message and the description under 
interrupt-name regarding the optional wakeup IRQ. I believe that address 
your query.

I can include minItems:1 in the interrupt-name property in the next 
patch set to align/sync with interrupts property.

Thanks,
Praveen Talari
> 
> I am not reviewing the rest. Implement complete feedback given to you in
> v4 and v5.
> 
> Best regards,
> Krzysztof
>