linux-kernel - Re: [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEf9OfSWjp7id68A@kekkonen.localdomain>
Date: Tue, 10 Jun 2025 09:39:05 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Benjamin Mugnier <benjamin.mugnier@...s.st.com>
Cc: Sylvain Petinot <sylvain.petinot@...s.st.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes

Hi Benjamin,

On Tue, Jun 10, 2025 at 11:31:05AM +0200, Benjamin Mugnier wrote:
> Hi Sakari,
> 
> Thank you for your review.
> 
> On 6/10/25 11:00, Sakari Ailus wrote:
> > Hi Benjamin,
> > 
> > Thanks for the set.
> > 
> > On Mon, Jun 09, 2025 at 03:46:20PM +0200, Benjamin Mugnier wrote:
> >> This series provides small fixes and style improvements to the vd55g1
> >> driver.
> >> Nothing fancy really, just to keep everything up to date.
> > 
> > On all (or at least more than one) patches:
> > 
> > - please add a proper commit message beyond the subject line and
> > 
> > - properly wrap the commit paragraphs (up to 75 characters per line, e.g.
> >   the above paragraph would fit on two lines).
> > 
> 
> Yes, commit descriptions have been added in v2. Media-ci rightfully
> yelled at me for that ;)
> 
> I don't see any commit paragraphs being above 75 characters, my vim
> seems to be properly configured.

It's not over 75 characters per line but some lines are shorter than they
could be.

> Do you mean the commit header too perhaps ? For example "media: i2c:
> vd55g1: Miscellaneous fixes".

-- 
Regards,

Sakari Ailus