linux-kernel - Re: [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEgCd7Z1rE6-K2Ac@smile.fi.intel.com>
Date: Tue, 10 Jun 2025 13:01:27 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Jonathan Corbet <corbet@....net>, ikepanhc@...il.com,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Armin Wolf <W_Armin@....de>, linux-doc@...r.kernel.org,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir

On Mon, Jun 09, 2025 at 09:21:45PM -0400, Mark Pearson wrote:
> On Mon, Jun 9, 2025, at 4:17 PM, Andy Shevchenko wrote:
> > On Mon, Jun 09, 2025 at 08:27:24AM -0400, Mark Pearson wrote:

...

> >> -F:	drivers/platform/x86/lenovo-wmi-hotkey-utilities.c
> >> +F:	drivers/platform/x86/lenovo/lenovo-wmi-hotkey-utilities.c
> >
> > Is this correct?
> >
> Jackie is on my team, he wrote this driver originally (with some help) for one of the thinkbook platforms.
> If there are any changes he should review them as he has access to the HW, but I'll be helping too.
> I think it's fine - let me know if otherwise.
> 
> Just as background: We can't use our Lenovo email addresses for kernel
> contributions. They're based on an awful Outlook server that is incapable of
> handling text only emails, and also won't play nice with any other tooling
> (including git send-email). Not ideal but it is what it is, and I gave up
> fighting with IT about it (there are some workarounds, but they're arguably
> worse).
> 
> > Otherwise LGTM.

What I'm talking about is the filename.

-- 
With Best Regards,
Andy Shevchenko