linux-kernel - Re: [PATCH v3 5/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7000f63e-5e68-465d-9d7f-1a6ca0524222@kernel.org>
Date: Tue, 10 Jun 2025 14:38:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Clement LE GOFFIC <clement.legoffic@...s.st.com>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 5/9] ARM: dts: stm32: add Hardware debug port (HDP) on
 stm32mp13

On 10/06/2025 14:02, Clement LE GOFFIC wrote:
> On 5/29/25 11:01, Krzysztof Kozlowski wrote:
>> On 28/05/2025 14:14, Clement LE GOFFIC wrote:
>>>>
>>>>> +		};
>>>>> +
>>>>> +		hdp: pinctrl@...2a000 {
>>>>> +			compatible = "st,stm32mp131-hdp";
>>>>> +			reg = <0x5002a000 0x400>;
>>>>> +			clocks = <&rcc HDP>;
>>>>>    			status = "disabled";
>>>>
>>>> Why are you disabling it? What is missing?
>>>
>>> Nothing is missing just disabled by default.
>>> The node is then enabled when needed in board's dts file.
>> Nodes should not be disabled by default if they are complete. That's why
>> I asked what is missing. Drop.
> 
> Hi Krzysztof, OK I better understand now.
> So yes the 'pinctrl-*' properties which are board dependent are lacking.

These are not properties of this node.

> 
> In the last patch of my serie I add them (only for stm32mp157f-dk2) but 
> keep it disabled because the pin is on an external connector (the 
> Arduino connector of the board).
> This prevent any issue with a possible connected module.

Not relevant. Pin control for connector are board specific, but pinctrl
SoC part is SoC.

Best regards,
Krzysztof