linux-kernel - Re: [PATCH net-next v1 3/3] net: phy: micrel: add cable test support for KSZ9477-class PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2da14336-66ae-4079-994c-a17597f13255@lunn.ch>
Date: Tue, 10 Jun 2025 14:38:10 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 3/3] net: phy: micrel: add cable test support
 for KSZ9477-class PHYs

On Tue, Jun 10, 2025 at 11:13:54AM +0200, Oleksij Rempel wrote:
> Enable cable test support for KSZ9477-class PHYs by reusing the
> existing KSZ9131 implementation.
> 
> This also adds support for 100Mbit-only PHYs like KSZ8563, which are
> identified as KSZ9477. For these PHYs, only two wire pairs (A and B)
> are active, so the cable test logic limits the pair_mask accordingly.
> 
> Support for KSZ8563 is untested but added based on its register
> compatibility and PHY ID match.
> 
> Tested on KSZ9893 (Gigabit): open and short conditions were correctly
> detected on all four pairs. Fault length reporting is functional and
> varies by pair. For example:
> - 2m cable: open faults reported ~1.2m (pairs B–D), 0.0m (pair A)
> - No cable: all pairs report 0.0m fault length
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew