linux-kernel - Re: [PATCH v2] pmdomain: Use str_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506111010521118VJaiO_pb0rD7b3daxqox@zte.com.cn>
Date: Wed, 11 Jun 2025 10:10:52 +0800 (CST)
From: <shao.mingyin@....com.cn>
To: <krzk@...nel.org>
Cc: <ulf.hansson@...aro.org>, <changhuang.liang@...rfivetech.com>,
        <geert+renesas@...der.be>, <magnus.damm@...il.com>, <heiko@...ech.de>,
        <alim.akhtar@...sung.com>, <walker.chen@...rfivetech.com>,
        <sebastian.reichel@...labora.com>, <detlev.casanova@...labora.com>,
        <finley.xiao@...k-chips.com>, <shawn.lin@...k-chips.com>,
        <pgwipeout@...il.com>, <qiu.yutan@....com.cn>,
        <linux-pm@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <yang.yang29@....com.cn>,
        <xu.xin16@....com.cn>, <yang.tao172@....com.cn>,
        <ye.xingchen@....com.cn>
Subject: Re: [PATCH v2] pmdomain: Use str_enable_disable-like helpers

>> From: Shao Mingyin <shao.mingyin@....com.cn>
>> 
>> Replace ternary (condition ? "enable" : "disable") syntax and ternary
>> (condition ? "on" : "off") syntax with helpers from
>> string_choices.h because:
>> 1. Simple function call with one argument is easier to read.  Ternary
>>    operator has three arguments and with wrapping might lead to quite
>>    long code.
>> 2. Is slightly shorter thus also easier to read.
>> 3. It brings uniformity in the text - same string.
>> 4. Allows deduping by the linker, which results in a smaller binary
>>    file.
>
>So you just taken everything from the same my patch - even entire commit
>subject and commit description - and sent it as yours?
>
>https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@linaro.org/
>
>oh my, if doing EXACTLY the same keep original authorship - the From and
>Sob fields.
>
>Best regards,
>Krzysztof
Dear Krzysztof,
Thank you for your suggestions. I have carefully read your advice and
made adjustments to the patches accordingly. I used your patch as a
reference standard, not just taking everything from the same your patch.

Based on your suggestion, I have consolidated the series of patches for
the pmdomain driver into a single patch. Additionally, following
@changhuang's suggestion, I have supplemented the patch for
drivers/pmdomain/starfive/jh71xx-pmu.c.

If there's anything inappropriate in this patch, I sincerely apologize.

Best regards,
Mingyin