linux-kernel - Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d482653e-5c0e-4b03-98d6-2c898b445917@quicinc.com>
Date: Wed, 11 Jun 2025 17:54:44 +0530
From: Akhil P Oommen <quic_akhilpo@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Akhil P Oommen
	<akhilpo@....qualcomm.com>,
        Catalin Marinas <catalin.marinas@....com>,
        "Will
 Deacon" <will@...nel.org>,
        Rob Clark <robin.clark@....qualcomm.com>, Sean
 Paul <sean@...rly.run>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Dmitry
 Baryshkov <lumag@...nel.org>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        Jessica Zhang <jessica.zhang@....qualcomm.com>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, "Simona
 Vetter" <simona@...ll.ch>,
        Bjorn Andersson <andersson@...nel.org>, Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>, Viresh Kumar <vireshk@...nel.org>,
        Nishanth
 Menon <nm@...com>, Stephen Boyd <sboyd@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP
 entry

On 6/11/2025 4:50 PM, Krzysztof Kozlowski wrote:
> On 11/06/2025 13:15, Akhil P Oommen wrote:
>> Update regex to allow multi-worded OPP entry names.
> 
> Why would we want multi-worded? This needs to be explained here.

I took the new regex from "opp-v2-base.yaml" file, so I thought it was
obvious enough. The requirement is that sometimes Adreno GPU may require
variants of OPP entries with same frequency. As an example, we may want
to vote different peak bandwidths in different SKUs for the same GPU
frequency. So to denote this minor variation, we can add an integer
suffix to the OPP entry name separated by '-'. An example from another
patch in this series:

 opp-666000000-0 {
         opp-hz = /bits/ 64 <666000000>;
         opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
         opp-peak-kBps = <8171875>;
         qcom,opp-acd-level = <0xa82d5ffd>;
         opp-supported-hw = <0xf>;
 };

 /* Only applicable for SKUs which has 666Mhz as Fmax */
 opp-666000000-1 {
         opp-hz = /bits/ 64 <666000000>;
         opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
         opp-peak-kBps = <16500000>;
         qcom,opp-acd-level = <0xa82d5ffd>;
         opp-supported-hw = <0x10>;
 };

I will add this explanation in the commit text in the next revision.

> 
> 
>>
>> Signed-off-by: Akhil P Oommen <akhilpo@....qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
>> index a27ba7b663d456f964628a91a661b51a684de1be..bba95799919eb52d12afa42354ed909d0ef3c627 100644
>> --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
>> @@ -23,7 +23,7 @@ properties:
>>        const: operating-points-v2-adreno
>>  
>>  patternProperties:
>> -  '^opp-[0-9]+$':
>> +  '^opp(-?[0-9]+)*$':
> 
> Not correct regex. You allow "opp", "opp1" and all other unusual
> variants. Commit does not explain what problem you are solving, so I
> have no clue what you want here, but for sure opp1 is wrong.

Just to confirm, would this be fine for the requirement I mentioned above?

"'^opp(-[0-9]+)*$'"

-Akhil.

> 
> 
> Best regards,
> Krzysztof