linux-kernel - Re: [PATCH v2 4/4] arm64: dts: qcom: Add GPU support to X1P42100 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1008a6c-6aa6-4e42-8d76-9aeaa708d41a@quicinc.com>
Date: Wed, 11 Jun 2025 17:55:30 +0530
From: Akhil P Oommen <quic_akhilpo@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Akhil P Oommen
	<akhilpo@....qualcomm.com>,
        Catalin Marinas <catalin.marinas@....com>,
        "Will
 Deacon" <will@...nel.org>,
        Rob Clark <robin.clark@....qualcomm.com>, Sean
 Paul <sean@...rly.run>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Dmitry
 Baryshkov <lumag@...nel.org>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        Jessica Zhang <jessica.zhang@....qualcomm.com>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, "Simona
 Vetter" <simona@...ll.ch>,
        Bjorn Andersson <andersson@...nel.org>, Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>, Viresh Kumar <vireshk@...nel.org>,
        Nishanth
 Menon <nm@...com>, Stephen Boyd <sboyd@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: Add GPU support to X1P42100 SoC

On 6/11/2025 4:52 PM, Krzysztof Kozlowski wrote:
> On 11/06/2025 13:15, Akhil P Oommen wrote:
>> +		opp-280000000 {
>> +			opp-hz = /bits/ 64 <280000000>;
>> +			opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>;
>> +			opp-peak-kBps = <2136719>;
>> +			qcom,opp-acd-level = <0xc82f5ffd>;
>> +			opp-supported-hw = <0x1f>;
>> +		};
>> +	};
>> +
>>  };
>>  
>>  &gpucc {
>> @@ -41,6 +150,13 @@ &pcie6a_phy {
>>  	compatible = "qcom,x1p42100-qmp-gen4x4-pcie-phy";
>>  };
>>  
>> +&qfprom {
>> +	gpu_speed_bin: gpu_speed_bin@119 {
> 
> No underscores. You need to align downstream code to upstream. See
> coding style.

Ack.

-Akhil

> 
> 
> 
> Best regards,
> Krzysztof