linux-kernel - Re: [PATCH net-next v4 09/11] net/mlx5e: Implement queue mgmt ops and single channel swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250611062654.5121229b@kernel.org>
Date: Wed, 11 Jun 2025 06:26:54 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mark Bloch <mbloch@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, <saeedm@...dia.com>, <gal@...dia.com>,
 <leonro@...dia.com>, <tariqt@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Dragos Tatulea <dtatulea@...dia.com>,
 "Cosmin Ratiu" <cratiu@...dia.com>
Subject: Re: [PATCH net-next v4 09/11] net/mlx5e: Implement queue mgmt ops
 and single channel swap

On Tue, 10 Jun 2025 18:09:48 +0300 Mark Bloch wrote:
> +	mdev = mlx5_sd_ch_ix_get_dev(priv->mdev, queue_index);
> +	err = mlx5e_build_channel_param(mdev, &params, &new->cparam);
> +	if (err) {
> +		return err;
> +		goto unlock;

missed this nugget yesterday, sorry..

> +	}