linux-kernel - Re: [PATCH net-next v4 01/11] net: Allow const args for of page_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izOzZnNRbBvMohGzB2rxhuLun8ZcPKg38Z1TbXo3stqZew@mail.gmail.com>
Date: Wed, 11 Jun 2025 21:52:47 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Mark Bloch <mbloch@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, saeedm@...dia.com, gal@...dia.com, 
	leonro@...dia.com, tariqt@...dia.com, Leon Romanovsky <leon@...nel.org>, 
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dragos Tatulea <dtatulea@...dia.com>, 
	Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net-next v4 01/11] net: Allow const args for of page_to_netmem()

On Tue, Jun 10, 2025 at 8:15 AM Mark Bloch <mbloch@...dia.com> wrote:
>
> From: Dragos Tatulea <dtatulea@...dia.com>
>
> This allows calling page_to_netmem() with a const page * argument.
>
> Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> Signed-off-by: Mark Bloch <mbloch@...dia.com>

This is slightly better, it returns a const netmem_ref if const struct page:

https://lore.kernel.org/netdev/20250609043225.77229-6-byungchul@sk.com/

It's probably too much of a hassle to block your series until
Byungchul's change to this helper goes in for you, so this seems fine
to me in the interim.

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

-- 
Thanks,
Mina