linux-kernel - Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o6uuxv8x.fsf@kernel.org>
Date: Wed, 11 Jun 2025 15:28:46 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Benno Lossin" <lossin@...nel.org>,  "Miguel Ojeda" <ojeda@...nel.org>,
  "Alex Gaynor" <alex.gaynor@...il.com>,  "Boqun Feng"
 <boqun.feng@...il.com>,  "Gary Guo" <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,  "Benno Lossin" <benno.lossin@...ton.me>,
  "Alice Ryhl" <aliceryhl@...gle.com>,  "Masahiro Yamada"
 <masahiroy@...nel.org>,  "Nathan Chancellor" <nathan@...nel.org>,  "Luis
 Chamberlain" <mcgrof@...nel.org>,  "Danilo Krummrich" <dakr@...nel.org>,
  "Nicolas Schier" <nicolas.schier@...ux.dev>,  "Trevor Gross"
 <tmgross@...ch.edu>,  "Adam Bratschi-Kaye" <ark.email@...il.com>,
  <rust-for-linux@...r.kernel.org>,  <linux-kernel@...r.kernel.org>,
  <linux-kbuild@...r.kernel.org>,  "Petr Pavlu" <petr.pavlu@...e.com>,
  "Sami Tolvanen" <samitolvanen@...gle.com>,  "Daniel Gomez"
 <da.gomez@...sung.com>,  "Simona Vetter" <simona.vetter@...ll.ch>,  "Greg
 KH" <gregkh@...uxfoundation.org>,  "Fiona Behrens" <me@...enk.dev>,
  "Daniel Almeida" <daniel.almeida@...labora.com>,
  <linux-modules@...r.kernel.org>
Subject: Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

"Miguel Ojeda" <miguel.ojeda.sandonis@...il.com> writes:

> On Wed, Jun 11, 2025 at 2:24 PM Andreas Hindborg <a.hindborg@...nel.org> wrote:
>>
>> So either we need to `#[allow(missing_docs)]` or just add the line back. What do you prefer?
>
> Do you mean if you remove the `concat!` too, right?

Yes, all of it.

>
> It would need to be `expect`, but I think even an
> `expect(missing_docs)` is not really useful vs. having some docs.
>
> But another question is: if the docs are not useful, should an item be
> hidden to begin with?

That is probably the best solution, yes.

> (By the way, that one is `rustc`, not Clippy)

Right.


Best regards,
Andreas Hindborg