linux-kernel - Re: [PATCH v5 7/7] kselftest/arm64/mte: add MTE_STORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEmOja7F5afmuosj@e129823.arm.com>
Date: Wed, 11 Jun 2025 15:11:25 +0100
From: Yeoreum Yun <yeoreum.yun@....com>
To: Mark Brown <broonie@...nel.org>
Cc: catalin.marinas@....com, pcc@...gle.com, will@...nel.org,
	anshuman.khandual@....com, joey.gouly@....com, maz@...nel.org,
	oliver.upton@...ux.dev, frederic@...nel.org,
	hardevsinh.palaniya@...iconsignals.io, samuel.holland@...ive.com,
	palmer@...osinc.com, charlie@...osinc.com,
	thiago.bauermann@...aro.org, bgray@...ux.ibm.com,
	tglx@...utronix.de, puranjay@...nel.org, david@...hat.com,
	yang@...amperecomputing.com, mbenes@...e.cz,
	joel.granados@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 7/7] kselftest/arm64/mte: add MTE_STORE_ONLY testcases

Hi Mark,

> On Wed, Jun 11, 2025 at 10:48:02AM +0100, Yeoreum Yun wrote:
>
> > @@ -144,7 +178,7 @@ static int check_file_memory_mapping(int mem_type, int mode, int mapping, int ta
> >  			close(fd);
> >  			return KSFT_FAIL;
> >  		}
> > -		result = check_mte_memory(ptr, sizes[run], mode, tag_check, atag_check);
> > +		result = check_mte_memory(ptr, sizes[run], mode, tag_check, atag_check, tag_op);
> >  		mte_clear_tags((void *)ptr, sizes[run]);
> >  		munmap((void *)map_ptr, map_size);
> >  		close(fd);
>
> check_file_memory_mapping() looks like it also has the issue from the
> other series with skips being upgraded to fails, looks like there's more
> instances.

Thanks. I've fixed this in
  - https://lore.kernel.org/all/20250611135818.31070-10-yeoreum.yun@arm.com/

> > @@ -106,11 +115,11 @@ int main(void)
> >  	int i;
> >
> >  	ksft_print_header();
> > -	ksft_set_plan(5);
> > +	ksft_set_plan(8);
> >
>
> This should probably have been ARRAY_SIZE() to start off with, sorry.

Okay. I'll fix this.


--
Sincerely,
Yeoreum Yun