linux-kernel - Re: [PATCH] net: ipconfig: replace strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH4c4jKcnmquBJ1fXo0ENRf+D3xuogF+Cu4iGVsR18FZfggqqw@mail.gmail.com>
Date: Wed, 11 Jun 2025 19:42:41 +0530
From: Pranav Tyagi <pranav.tyagi03@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, skhan@...uxfoundation.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] net: ipconfig: replace strncpy with strscpy

On Sat, Jun 7, 2025 at 10:12 PM Simon Horman <horms@...nel.org> wrote:
>
> On Sat, Jun 07, 2025 at 08:58:30PM +0530, Pranav Tyagi wrote:
> > Replace the deprecated strncpy() with strscpy() as the destination
> > buffer is NUL-terminated and does not require any
> > trailing NUL-padding. Also increase the length to 252
> > as NUL-termination is guaranteed.
> >
> > Signed-off-by: Pranav Tyagi <pranav.tyagi03@...il.com>
>
> Hi Pranav,
>
> As a non-bug fix for Networking code this should be targeted
> at net-next. And it's helpful to do so explicitly in the patch subject,
> like this:
>
>         [PATCH v2 net-next] ...
>
> Also, unfortunately the timing of this patch is not good
> as net-next is currently closed for the merge window.
>
> You can find more information about the above,
> and other aspects of the workflow for the Networking subsystem
> in https://docs.kernel.org/process/maintainer-netdev.html
>
>
> ## Form letter - net-next-closed
>
> The merge window for v6.16 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations. We are
> currently accepting bug fixes only.
>
> Please repost when net-next reopens after June 8th.
>
> RFC patches sent for review only are obviously welcome at any time.
>
> --
> pw-bot: defer

Hi,

Thanks for pointing out the shortcomings in the patch.
The doc will help a lot. I will correct the patch accordingly and
send the v2 as the merge window has reopened.

Regards

Pranav Tyagi