linux-kernel - Re: [PATCH] Input: tca6416-keypad - Add OF support for driver instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506112236.gn3kTosZ-lkp@intel.com>
Date: Wed, 11 Jun 2025 22:22:39 +0800
From: kernel test robot <lkp@...el.com>
To: Tomáš Juřena <jurenatomas@...il.com>,
	dmitry.torokhov@...il.com
Cc: oe-kbuild-all@...ts.linux.dev, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tomas Jurena <jurenatomas@...il.com>
Subject: Re: [PATCH] Input: tca6416-keypad - Add OF support for driver
 instantiation

Hi Tomáš,

kernel test robot noticed the following build warnings:

[auto build test WARNING on dtor-input/next]
[also build test WARNING on dtor-input/for-linus linus/master v6.16-rc1 next-20250611]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tom-Ju-ena/Input-tca6416-keypad-Add-OF-support-for-driver-instantiation/20250611-094643
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link:    https://lore.kernel.org/r/20250610154609.1382818-1-jurenatomas%40gmail.com
patch subject: [PATCH] Input: tca6416-keypad - Add OF support for driver instantiation
config: arm-randconfig-001-20250611 (https://download.01.org/0day-ci/archive/20250611/202506112236.gn3kTosZ-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250611/202506112236.gn3kTosZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506112236.gn3kTosZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/input/keyboard/tca6416-keypad.c: In function 'tca6416_parse_properties':
>> drivers/input/keyboard/tca6416-keypad.c:194:12: warning: unused variable 'pin' [-Wunused-variable]
     194 |         u8 pin;
         |            ^~~


vim +/pin +194 drivers/input/keyboard/tca6416-keypad.c

   185	
   186	static struct tca6416_keys_platform_data *
   187	tca6416_parse_properties(struct device *dev, uint8_t io_size)
   188	{
   189		static const char keymap_property[] = "linux,gpio-keymap";
   190		struct tca6416_keys_platform_data *pdata;
   191		u32 keymap[TCA6416_MAX_IO_SIZE];
   192		struct tca6416_button *buttons;
   193		int ret, i;
 > 194		u8 pin;
   195	
   196		pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
   197		if (!pdata)
   198			return NULL;
   199	
   200		ret = device_property_count_u32(dev, keymap_property);
   201		if (ret <= 0)
   202			return NULL;
   203	
   204		pdata->nbuttons = ret;
   205		if (pdata->nbuttons > io_size)
   206			pdata->nbuttons = io_size;
   207	
   208		ret = device_property_read_u32_array(dev, keymap_property, keymap,
   209						     pdata->nbuttons);
   210		if (ret)
   211			return NULL;
   212	
   213		buttons = devm_kcalloc(dev, pdata->nbuttons, sizeof(*buttons),
   214				       GFP_KERNEL);
   215		if (!buttons)
   216			return NULL;
   217	
   218		for (i = 0; i < pdata->nbuttons; i++) {
   219			buttons[i].code = FIELD_GET(CFG_CODE, keymap[i]);
   220			buttons[i].type = FIELD_GET(CFG_TYPE, keymap[i]);
   221			buttons[i].active_low = FIELD_GET(CFG_ACTIVE_LOW, keymap[i]);
   222			/* enable all inputs by default */
   223			pdata->pinmask |= BIT(i);
   224		}
   225	
   226		pdata->buttons = buttons;
   227	
   228		pdata->rep = device_property_read_bool(dev, "autorepeat");
   229		/* we can ignore the result as by default all inputs are enabled */
   230		device_property_read_u16(dev, "pinmask", &pdata->pinmask);
   231		pdata->use_polling = device_property_read_bool(dev, "polling");
   232	
   233		return pdata;
   234	}
   235	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki