linux-kernel - Re: [PATCH] Input: tca6416-keypad - Add OF support for driver instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEmp57H3Tk6DnJty@jurenat-workstationFai>
Date: Wed, 11 Jun 2025 18:08:07 +0200
From: Tomas Jurena <jurenatomas@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: dmitry.torokhov@...il.com, krzk+dt@...nel.org, conor+dt@...nel.org,
	linux-input@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: tca6416-keypad - Add OF support for driver
 instantiation

On Tue, Jun 10, 2025 at 01:15:42PM -0500, Rob Herring wrote:
> On Tue, Jun 10, 2025 at 05:46:10PM +0200, Tomáš Juřena wrote:
> > From: Tomas Jurena <jurenatomas@...il.com>
> > 
> > Adds support for instantiating the tca6416-keypad driver via
> > Device Tree. If no platform data is present, the driver can now be
> > probed based on OF bindings.
> > 
> > A corresponding Device Tree binding document is added at:
> >   Documentation/devicetree/bindings/input/tca6416-keypad.yaml
> > 
> > This allows the driver to be used in systems that rely solely on the
> > Device Tree for hardware description, such as embedded ARM platforms.
> > 
> > Tested on Toradex Ixora 1.3A board and Apalis imx8 SOM.
> 
> We already have a GPIO driver for this chip. Would the 
> gpio-keys driver work here instead? Seems to work for 
> arch/arm/boot/dts/ti/omap/am3517-evm-ui.dtsi.
>
I was not aware of this. Anyway, I tested this today, and it seems to work just fine with my hardware. There is no need for this change from my side.