linux-kernel - Re: [PATCH] Input: tca6416-keypad - Add OF support for driver instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <meakn5o4tjnl55ykk5fvrpc3f7g4ov2gqfdsxzzy44p7zvrrit@53y6xkkhwcmx>
Date: Wed, 11 Jun 2025 10:44:21 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Tomas Jurena <jurenatomas@...il.com>
Cc: Rob Herring <robh@...nel.org>, krzk+dt@...nel.org, conor+dt@...nel.org, 
	linux-input@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: tca6416-keypad - Add OF support for driver
 instantiation

On Wed, Jun 11, 2025 at 06:08:07PM +0200, Tomas Jurena wrote:
> On Tue, Jun 10, 2025 at 01:15:42PM -0500, Rob Herring wrote:
> > On Tue, Jun 10, 2025 at 05:46:10PM +0200, Tomáš Juřena wrote:
> > > From: Tomas Jurena <jurenatomas@...il.com>
> > > 
> > > Adds support for instantiating the tca6416-keypad driver via
> > > Device Tree. If no platform data is present, the driver can now be
> > > probed based on OF bindings.
> > > 
> > > A corresponding Device Tree binding document is added at:
> > >   Documentation/devicetree/bindings/input/tca6416-keypad.yaml
> > > 
> > > This allows the driver to be used in systems that rely solely on the
> > > Device Tree for hardware description, such as embedded ARM platforms.
> > > 
> > > Tested on Toradex Ixora 1.3A board and Apalis imx8 SOM.
> > 
> > We already have a GPIO driver for this chip. Would the 
> > gpio-keys driver work here instead? Seems to work for 
> > arch/arm/boot/dts/ti/omap/am3517-evm-ui.dtsi.
> >
> I was not aware of this. Anyway, I tested this today, and it seems to work just fine with my hardware. There is no need for this change from my side.

I wonder if we should simply remove tca6416-keypad driver. I guess it
was created before we has a gpio driver for this block.

Thanks.

-- 
Dmitry