linux-kernel - Re: [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d87fa3b-c3b9-44fd-9e61-7f1ffadcfb0c@ti.com>
Date: Wed, 11 Jun 2025 16:13:05 -0500
From: Andrew Davis <afd@...com>
To: Kory Maincent <kory.maincent@...tlin.com>,
        Tony Lindgren
	<tony@...mide.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Aaro Koskinen
	<aaro.koskinen@....fi>,
        Andreas Kemnade <andreas@...nade.info>,
        Kevin Hilman
	<khilman@...libre.com>,
        Roger Quadros <rogerq@...nel.org>,
        Russell King
	<linux@...linux.org.uk>
CC: Bajjuri Praneeth <praneeth@...com>, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Thomas Petazzoni
	<thomas.petazzoni@...tlin.com>,
        <linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219
 regulator

On 6/9/25 10:43 AM, Kory Maincent wrote:
> Enable the TPS65219 regulator in the defconfig, as the TPS65214
> variant is used by the newly introduced BeagleBoard Green Eco board.
> 
> Reviewed-by: Andreas Kemnade <andreas@...nade.info>
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---
>   arch/arm/configs/omap2plus_defconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 9f9780c8e62a..2ad669f7b202 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig

Why omap2plus_defconfig? OMAP3 and newer are all ARMv7 and
boards with those can/should use multi_v7_defconfig.

OMAP1 and OMAP2 are the only devices that cannot use multi_v7_defconfig
as they are not ARMv7. So I'd almost recommend we rename
omap2plus_defconfig to just omap2_defconfig to avoid more confusion.
Then we would have:

OMAP1:  ARMv4/5: omap1_defconfig
OMAP2:  ARMv6:   omap2_defconfig
OMAP3+: ARMv7:   multi_v7_defconfig

Any issue with that I'm missing?

Andrew

> @@ -385,6 +385,7 @@ CONFIG_TOUCHSCREEN_TSC2007=m
>   CONFIG_INPUT_MISC=y
>   CONFIG_INPUT_CPCAP_PWRBUTTON=m
>   CONFIG_INPUT_TPS65218_PWRBUTTON=m
> +CONFIG_INPUT_TPS65219_PWRBUTTON=m
>   CONFIG_INPUT_TWL4030_PWRBUTTON=m
>   CONFIG_INPUT_UINPUT=m
>   CONFIG_INPUT_PALMAS_PWRBUTTON=m
> @@ -454,6 +455,7 @@ CONFIG_MFD_TPS65217=y
>   CONFIG_MFD_TI_LP873X=y
>   CONFIG_MFD_TI_LP87565=y
>   CONFIG_MFD_TPS65218=y
> +CONFIG_MFD_TPS65219=y
>   CONFIG_MFD_TPS65910=y
>   CONFIG_TWL6040_CORE=y
>   CONFIG_REGULATOR_CPCAP=y
> @@ -470,6 +472,7 @@ CONFIG_REGULATOR_TPS65023=y
>   CONFIG_REGULATOR_TPS6507X=y
>   CONFIG_REGULATOR_TPS65217=y
>   CONFIG_REGULATOR_TPS65218=y
> +CONFIG_REGULATOR_TPS65219=y
>   CONFIG_REGULATOR_TPS65910=y
>   CONFIG_REGULATOR_TWL4030=y
>   CONFIG_RC_CORE=m
>