linux-kernel - Re: [PATCH v2 03/17] regulator: dt-bindings: add s2mpg11-pmic regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250611-spectral-bullfrog-of-perfection-cb8e01@kuoka>
Date: Wed, 11 Jun 2025 10:57:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Peter Griffin <peter.griffin@...aro.org>, Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com, 
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 03/17] regulator: dt-bindings: add s2mpg11-pmic
 regulators

On Fri, Jun 06, 2025 at 04:02:59PM GMT, André Draszik wrote:
> The S2MPG11 PMIC is a Power Management IC for mobile applications with
> buck converters, various LDOs, power meters, and additional GPIO
> interfaces. It typically complements an S2MPG10 PMIC in a main/sub
> configuration as the sub-PMIC.
> 
> S2MPG11 has 12 buck, 1 buck-boost, and 15 LDO rails. Several of these
> can either be controlled via software or via external signals, e.g.
> input pins connected to a main processor's GPIO pins.
> 
> Add documentation related to the regulator (buck & ldo) parts like
> devicetree definitions, regulator naming patterns, and additional
> properties.
> 
> Since S2MPG11 is typically used as the sub-PMIC together with an
> S2MPG10 as the main-PMIC, the datasheet and the binding both suffix the
> rails with an 's'.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> 
> ---
> Note: checkpatch suggests to update MAINTAINERS, but the new file is
> covered already due to using a wildcard.
> 
> v2:
> - fix commit message typos: s2mp1 -> s2mpg1
> - mention GPIOs in commit message
> ---
>  .../regulator/samsung,s2mpg11-regulator.yaml       | 150 +++++++++++++++++++++
>  .../regulator/samsung,s2mpg10-regulator.h          |  18 +++
>  2 files changed, 168 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpg11-regulator.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpg11-regulator.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..f2d596642501c197e2911ee3b9caac189cf541a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpg11-regulator.yaml
> @@ -0,0 +1,150 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/samsung,s2mpg11-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S2MPG11 Power Management IC regulators
> +
> +maintainers:
> +  - André Draszik <andre.draszik@...aro.org>
> +
> +description: |
> +  This is part of the device tree bindings for the S2MG11 Power Management IC
> +  (PMIC).
> +
> +  The S2MPG11 PMIC provides 12 buck, 1 buck-boost, and 15 LDO regulators.
> +
> +  See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
> +  additional information and example.
> +
> +definitions:
> +  s2mpg11-ext-control:
> +    properties:
> +      samsung,ext-control:
> +        description: |
> +          These rails can be controlled via one of several possible external
> +          (hardware) signals. If so, this property configures the signal the PMIC
> +          should monitor. The following values generally corresponding to the
> +          respective on-chip pin are valid:
> +            - 0 # S2MPG11_PCTRLSEL_ON - always on

Use regulator-always-on

> +            - 1 # S2MPG11_PCTRLSEL_PWREN - PWREN pin

That's duplicating regulator in standby properties.

> +            - 2 # S2MPG11_PCTRLSEL_PWREN_TRG - PWREN_TRG bit in MIMICKING_CTRL
> +            - 3 # S2MPG11_PCTRLSEL_PWREN_MIF - PWREN_MIF pin
> +            - 4 # S2MPG11_PCTRLSEL_PWREN_MIF_TRG - PWREN_MIF_TRG bit in MIMICKING_CTRL
> +            - 5 # S2MPG11_PCTRLSEL_AP_ACTIVE_N - ~AP_ACTIVE_N pin
> +            - 6 # S2MPG11_PCTRLSEL_AP_ACTIVE_N_TRG - ~AP_ACTIVE_N_TRG bit in MIMICKING_CTRL
> +            - 7 # S2MPG11_PCTRLSEL_G3D_EN - G3D_EN pin
> +            - 8 # S2MPG11_PCTRLSEL_G3D_EN2 - G3D_EN & ~AP_ACTIVE_N pins
> +            - 9 # S2MPG11_PCTRLSEL_AOC_VDD - AOC_VDD pin
> +            - 10 # S2MPG11_PCTRLSEL_AOC_RET - AOC_RET pin
> +            - 11 # S2MPG11_PCTRLSEL_UFS_EN - UFS_EN pin

Now I have doubts these are real signals. Are you saying that S2MPG11
has a pin named UFS_EN (such pin on ballmap)?

> +            - 12 # S2MPG11_PCTRLSEL_LDO13S_EN - VLDO13S_EN pin
> +
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 12
> +
> +      samsung,ext-control-gpios:

Same comments as previous patch.

Best regards,
Krzysztof