linux-kernel - Re: [PATCH v2 04/17] dt-bindings: mfd: samsung,s2mps11: add s2mpg10-pmic regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250611-fierce-whimsical-aardwolf-6cd33b@kuoka>
Date: Wed, 11 Jun 2025 11:03:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Peter Griffin <peter.griffin@...aro.org>, Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com, 
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 04/17] dt-bindings: mfd: samsung,s2mps11: add
 s2mpg10-pmic regulators

On Fri, Jun 06, 2025 at 04:03:00PM GMT, André Draszik wrote:
> Add a regulators node to the s2mpg10-pmic to describe the regulators
> available on this PMIC.
> 
> Additionally, describe the supply inputs of the regulator rails, with
> the supply names matching the datasheet.
> 
> Note 1: S2MPG10 is typically used as the main-PMIC together with an
> S2MPG11 PMIC in a main/sub configuration, hence the datasheet and the
> binding both suffix the supplies with an 'm'.
> 
> Note 2: The binding needs to switch from 'additionalProperties' to
> 'unevaluatedProperties', to allow adding the specific -supply
> properties for S2MPG10 only, as otherwise we'd have to resort to a
> global wildcard with negating inside each of the compatible matches.

I think this binding is getting too complicated. Maybe s2mpgXX should
have their own file.

Best regards,
Krzysztof