linux-kernel - Re: [PATCH v10 2/5] crypto: loongson

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aElLJY9MnkEQx935@gondor.apana.org.au>
Date: Wed, 11 Jun 2025 17:23:49 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Qunqin Zhao <zhaoqunqin@...ngson.cn>
Cc: lee@...nel.org, jarkko@...nel.org, linux-kernel@...r.kernel.org,
	loongarch@...ts.linux.dev, davem@...emloft.net,
	linux-crypto@...r.kernel.org, peterhuewe@....de, jgg@...pe.ca,
	linux-integrity@...r.kernel.org,
	Yinggang Gu <guyinggang@...ngson.cn>,
	Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v10 2/5] crypto: loongson - add Loongson RNG driver
 support

On Wed, May 28, 2025 at 02:59:41PM +0800, Qunqin Zhao wrote:
>
> +	if (!rng_devices.is_init) {
> +		ret = crypto_register_rng(&loongson_rng_alg);
> +		if (ret) {
> +			dev_err(&pdev->dev, "failed to register crypto(%d)\n", ret);
> +			return ret;
> +		}
> +		INIT_LIST_HEAD(&rng_devices.list);
> +		mutex_init(&rng_devices.lock);
> +		rng_devices.is_init = true;
> +	}

This doesn't look right.  What stops two devices from both entering
this code path when is_init == false?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt