linux-kernel - Re: [PATCH v10 2/5] crypto: loongson

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4efdb35f-dfb0-c44f-b3ec-7ca98717820c@loongson.cn>
Date: Tue, 17 Jun 2025 17:49:53 +0800
From: Qunqin Zhao <zhaoqunqin@...ngson.cn>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: lee@...nel.org, jarkko@...nel.org, linux-kernel@...r.kernel.org,
 loongarch@...ts.linux.dev, davem@...emloft.net,
 linux-crypto@...r.kernel.org, peterhuewe@....de, jgg@...pe.ca,
 linux-integrity@...r.kernel.org, Yinggang Gu <guyinggang@...ngson.cn>,
 Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v10 2/5] crypto: loongson - add Loongson RNG driver
 support


在 2025/6/11 下午5:23, Herbert Xu 写道:
> On Wed, May 28, 2025 at 02:59:41PM +0800, Qunqin Zhao wrote:
>> +	if (!rng_devices.is_init) {
>> +		ret = crypto_register_rng(&loongson_rng_alg);
>> +		if (ret) {
>> +			dev_err(&pdev->dev, "failed to register crypto(%d)\n", ret);
>> +			return ret;
>> +		}
>> +		INIT_LIST_HEAD(&rng_devices.list);
>> +		mutex_init(&rng_devices.lock);
>> +		rng_devices.is_init = true;
>> +	}
> This doesn't look right.  What stops two devices from both entering
> this code path when is_init == false?

Will use __MUTEX_INITIALIZER  macro to statically initialize 
rng_devices. lock,

and then use this lock to stop two devices form both entering this code 
path.


Thanks,

Qunqin

>
> Cheers,