linux-kernel - Re: [PATCH 1/2] dt-bindings: display: panel: document Synaptics TDDI panel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250612-patriarch-triage-8ceeebc6da4a@spud>
Date: Thu, 12 Jun 2025 16:53:00 +0100
From: Conor Dooley <conor@...nel.org>
To: Kaustabh Chakraborty <kauschluss@...root.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
	Jessica Zhang <quic_jesszhan@...cinc.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jessica Zhang <jessica.zhang@....qualcomm.com>,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: document Synaptics TDDI
 panel driver

On Thu, Jun 12, 2025 at 03:47:55PM +0000, Kaustabh Chakraborty wrote:
> On 2025-06-12 15:32, Conor Dooley wrote:
> > On Thu, Jun 12, 2025 at 08:09:40PM +0530, Kaustabh Chakraborty wrote:
> >> Document the driver for Synaptics TDDI (Touch/Display Integration) panels.
> >> Along with the MIPI-DSI panel, these devices also have an in-built LED
> >> backlight device and a touchscreen, all packed together in a single chip.
> >> Also, add compatibles for supported panels - TD4101 and TD4300.
> >> 
> >> Signed-off-by: Kaustabh Chakraborty <kauschluss@...root.org>
> >> ---
> >>  .../bindings/display/panel/synaptics,tddi.yaml     | 92 ++++++++++++++++++++++
> >>  1 file changed, 92 insertions(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,tddi.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,tddi.yaml
> >> new file mode 100644
> >> index 0000000000000000000000000000000000000000..3aae1358a1d764361c072d3b54f74cdf634f7fa8
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/display/panel/synaptics,tddi.yaml
> > 
> > File called synaptics,tddi
> > 
> >> @@ -0,0 +1,92 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/display/panel/samsung,tddi.yaml#
> > 
> > id of samsung,tddi
> > 
> > [...]
> >
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - syna,td4101-panel
> >> +      - syna,td4300-panel
> > 
> > compatibles are syna,td####-panel
> > 
> > These should be consistent and tooling should have complained about the
> > mismatch between id and filename at the least.
> 
> Hmm, I don't recall seeing any errors. Do I pick any one then? Or is there
> any other generic way?

The id must match the filename and the filename should match one of the
compatibles.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)